Conversation
WalkthroughThe GitHub Actions workflow for releasing the Wren-UI image has been updated. The command that creates and pushes the manifest list now appends the additional tag Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ui-release-image-stable.yaml (1)
90-93: Ensure Proper Concatenation and Quoting for the TAGS VariableThe change to append the
--tag latestflag meets the PR objective, but the current single-line assignment:TAGS=$(echo "${{ steps.meta.outputs.tags }}" | awk '{printf "--tag %s ", $0}') --tag latestmay lead to unexpected shell behavior. The extra
--tag latestappears outside the command substitution, which means it might not be captured as part ofTAGSand could result in a syntax or runtime error. To reliably concatenate the existing tags with the"--tag latest"flag, consider either wrapping the entire expression in quotes or splitting the assignment into two clear steps.A suggested refactor is:
- TAGS=$(echo "${{ steps.meta.outputs.tags }}" | awk '{printf "--tag %s ", $0}') --tag latest + BASE_TAGS=$(echo "${{ steps.meta.outputs.tags }}" | awk '{printf "--tag %s ", $0}') + TAGS="${BASE_TAGS} --tag latest"This approach first captures the base tags into
BASE_TAGSand then concatenates the additional flag with proper quoting, ensuring that any whitespace is handled correctly.
2 participants
add latest tag to ui image
Summary by CodeRabbit